Add `AwsCredentialFeatures` to Credential Providers #4238

landonxjames · 2025-07-28T19:50:02Z

Motivation and Context

Continuing the work in #4224, adding user-agent feature tracking for Credential Providers.

Description

Added AwsCredentialFeatures properties for each implementor of ProvideCredentials in aws-config.

Testing

Added integration tests for each of the supported Credential Providers. This required exposing some previously pub(crate) utility functions as pub under a test-util feature flag.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Also add related integration test for IMDS creds

github-actions · 2025-07-28T20:11:46Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
Server Test Python (ignoring whitespace)
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

…al-providers

github-actions · 2025-07-28T21:22:45Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
Server Test Python (ignoring whitespace)
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2025-07-28T22:20:11Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
Server Test Python (ignoring whitespace)
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

github-actions · 2025-07-29T03:28:06Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
Server Test Python (ignoring whitespace)
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

aajtodd

Overall looks good. It seems like we made a lot of stuff public or behind a test-util feature to allow testing via sdk/integration-tests. Part of me wonders if we wouldn't be better off making these unit tests in aws-config OR updating our integration tests to assert a specific UA credential feature

e.g.

make_test!(prefer_environment, feature: AwsCredentialFeature::CredentialsEnvVars)

That way we don't have to expose a bunch of test utilities just for this. I'm slightly concerned about having to maintain a bunch of things in test-util because we made them public but open to discussion.

aws/rust-runtime/aws-runtime/src/user_agent/test_util.rs

ysaito1001 · 2025-07-29T15:21:37Z

It seems like we made a lot of stuff public or behind a test-util feature to allow testing via sdk/integration-tests. Part of me wonders if we wouldn't be better off making these unit tests in aws-config

Good point. We should generally place tests in sdk/integration-tests only when tests are something specific about those target services. For instance, the test logic in imds_ua_feature can equally apply to any services, so probably better off having those tests in aws-config and making newly exposed test-utils back to pub(crate) 🤔

ysaito1001

Will circle back for the test part, but looks great. Thank you for making this change 👍

…nfig test-utils Move remaining test into S3 tests since that kind of serves as our catch all for random features

landonxjames · 2025-07-29T20:46:15Z

We discussed offline and decided that the best course of action, to avoid exposing new pub test-util functions, is to test the credentials features are added in aws-config and only retain some of the tests that don't need new test-util functionality in integration tests. This work was done in:

63f2134 adding tests to aws-config
eda2912 removing the newly expose test-utils
37276c5 removing the now broken integration tests and moving the remaining ones to the S3 test crate

github-actions · 2025-07-29T21:06:32Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
Server Test Python (ignoring whitespace)
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

ysaito1001

There is a CI failure, but the changes look good.

aws/sdk/integration-tests/s3/tests/credential_features.rs

github-actions · 2025-07-30T03:38:27Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
Server Test Python (ignoring whitespace)
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

aws/rust-runtime/aws-config/external-types.toml

github-actions · 2025-07-30T18:05:03Z

A new generated diff is ready to view.

AWS SDK (ignoring whitespace)
Client Test (ignoring whitespace)
No codegen difference in the Server Test
Server Test Python (ignoring whitespace)
No codegen difference in the Server Test Typescript

A new doc preview is ready to view.

## Motivation and Context   Merging the feature branch containing work from the below two PRs: * #4238 * #4224 ## Checklist  - [x] For changes to the AWS SDK, generated SDK code, or SDK runtime crates, I have created a changelog entry Markdown file in the `.changelog` directory, specifying "aws-sdk-rust" in the `applies_to` key. ---- _By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice._ --------- Co-authored-by: AWS SDK Rust Bot <[email protected]>

landonxjames added 3 commits July 24, 2025 14:26

Add AwsCredentialFeature to all ProvideCredential impls in aws-config

c799b9d

Populate AwsCredentialFeatures to Credential providers

47c193c

Also add related integration test for IMDS creds

Add integration tests for remaining credential features

c177bc6

Merge branch 'feature/credential-features' into landonxjames/credenti…

d643358

…al-providers

landonxjames marked this pull request as ready for review July 28, 2025 21:27

landonxjames requested a review from a team as a code owner July 28, 2025 21:27

Make aws-config/test-util enable tokio/test-util

668ceae

Update aws-config external types

5b05c0f

aajtodd reviewed Jul 29, 2025

View reviewed changes

aws/rust-runtime/aws-runtime/src/user_agent/test_util.rs Outdated Show resolved Hide resolved

ysaito1001 reviewed Jul 29, 2025

View reviewed changes

landonxjames added 3 commits July 29, 2025 12:05

Add tests for AwsCredentialFeatures

63f2134

Undo some of the new test-utils that were exposed

eda2912

Remove credential feature integration tests that relied on new aws-co…

37276c5

…nfig test-utils Move remaining test into S3 tests since that kind of serves as our catch all for random features

Remove errant test-util

22b335e

ysaito1001 approved these changes Jul 29, 2025

View reviewed changes

aws/sdk/integration-tests/s3/tests/credential_features.rs Outdated Show resolved Hide resolved

aajtodd approved these changes Jul 30, 2025

View reviewed changes

aws/rust-runtime/aws-config/external-types.toml Outdated Show resolved Hide resolved

Final cleanup

eca63ea

landonxjames merged commit fa922a5 into feature/credential-features Jul 30, 2025
45 checks passed

landonxjames deleted the landonxjames/credential-providers branch July 30, 2025 18:39

landonxjames mentioned this pull request Jul 30, 2025

Merge feature/credential-features branch to main #4240

Merged

1 task

Add AwsCredentialFeatures to Credential Providers #4238

Add AwsCredentialFeatures to Credential Providers #4238

Uh oh!

Conversation

landonxjames commented Jul 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation and Context

Description

Testing

Uh oh!

github-actions bot commented Jul 28, 2025

Uh oh!

github-actions bot commented Jul 28, 2025

Uh oh!

github-actions bot commented Jul 28, 2025

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

aajtodd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ysaito1001 commented Jul 29, 2025

Uh oh!

ysaito1001 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

landonxjames commented Jul 29, 2025

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

ysaito1001 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Jul 30, 2025

Uh oh!

Uh oh!

github-actions bot commented Jul 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add `AwsCredentialFeatures` to Credential Providers #4238

Add `AwsCredentialFeatures` to Credential Providers #4238

landonxjames commented Jul 28, 2025 •

edited

Loading

ysaito1001 left a comment •

edited

Loading